chore: add agent skills for unit and API e2e tests (CM-968) - #4402
Merged
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds reusable agent skills for standardized unit and API end-to-end test generation.
Changes:
- Adds Vitest unit-testing guidance.
- Adds Public API e2e testing guidance.
- References testing ADRs and infrastructure from #4398.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.claude/skills/write-unit-tests/SKILL.md |
Defines the unit-test workflow and guardrails. |
.claude/skills/write-api-e2e-tests/SKILL.md |
Defines the API e2e workflow and execution guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.claude/skills/write-api-e2e-tests/SKILL.md:42
- The documented runtime cannot make this step green for a new or changed endpoint on the current branch: ADR-0012 deploys and tests
main, and the workflow explicitly checks outmainbefore deploying (.github/workflows/api-e2e-tests.yml:23-26). The later reference to “local development workflows” does not help because neither ADR documents a local API setup. Please either document a supported local branch deployment/setup, or make this step conditional and report runtime validation as deferred until the endpoint reachesmain.
4. Run the affected suite locally and fix failures until green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write-unit-testsandwrite-api-e2e-testsClaude agent skillsNotes
Test plan
.claude/skills/